Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 12, 2019

ast.parse("None") was added/used in 3e6f1fa for differences between
Python 2/3, but we do not support py2 anymore.

@blueyed blueyed requested a review from Tadaboody August 12, 2019 05:50
`ast.parse("None")` was added/used in 3e6f1fa for differences between
Python 2/3, but we do not support py2 anymore.
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made this change in #5673, so LGTM. I think using constants for this is a bit much, but OK either way.

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #5732 into features will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5732      +/-   ##
============================================
+ Coverage     96.25%   96.27%   +0.01%     
============================================
  Files           117      117              
  Lines         25895    25896       +1     
  Branches       2494     2494              
============================================
+ Hits          24926    24931       +5     
+ Misses          666      663       -3     
+ Partials        303      302       -1
Impacted Files Coverage Δ
src/_pytest/assertion/rewrite.py 96.86% <100%> (ø) ⬆️
testing/test_assertrewrite.py 85.38% <0%> (+0.13%) ⬆️
testing/test_pytester.py 89.53% <0%> (+0.29%) ⬆️
src/_pytest/pastebin.py 91.22% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300f785...39ba996. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 12, 2019

Thanks for the review!

I think using constants for this is a bit much, but OK either way.

Not sure either, but thought that this gets called/used a lot after all.

@bluetech bluetech merged commit 67ac878 into pytest-dev:features Aug 12, 2019
@bluetech
Copy link
Member

This seems trivial enough for me to merge, so I did. Also to avoid conflict when rebasing the above mentioned PR.

@blueyed blueyed deleted the drop-py2 branch August 12, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants