Show session duration in human-readable format #5721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
summary-human-time-5707
branch
from
db3498d to
345df99
Compare
Codecov Report
@@ Coverage Diff @@
## features #5721 +/- ##
============================================
- Coverage 96.25% 96.21% -0.04%
============================================
Files 117 117
Lines 25889 25895 +6
Branches 2494 2494
============================================
- Hits 24919 24915 -4
- Misses 666 674 +8
- Partials 304 306 +2
Continue to review full report at Codecov.
|
blueyed
approved these changes
Aug 10, 2019
| return "{:.2f}s".format(seconds) | ||
| else: | ||
| dt = datetime.timedelta(seconds=int(seconds)) | ||
| return "{:.2f}s ({})".format(seconds, dt) |
There was a problem hiding this comment.
Does not really need the "else".
There was a problem hiding this comment.
I'm aware, I usually like to be explicit thought (it is a matter of style after all).
|
Yay \o/
(after quitting a left-over pdb instance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5707