Skip to content

Conversation

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Aug 8, 2019

See #5709 and the mails linked from there. I added a list of people included in [email protected] at the bottom.

See #5709 and the mails linked from there
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #5711 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5711      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.01%     
==========================================
  Files         117      117              
  Lines       25864    25864              
  Branches     2498     2498              
==========================================
- Hits        24875    24873       -2     
- Misses        689      690       +1     
- Partials      300      301       +1
Impacted Files Coverage Δ
src/_pytest/pastebin.py 87.71% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e772bb6...0a19439. Read the comment docs.

@nicoddemus
Copy link
Member

Looks good!

I believe we should add this to the docs (so it needs to be converted to .rst), and link it from the README too to gain more visibility.

besides being on the docs, I think it deserves to appear on the side bar too:

image

Perhaps after "Contributing"?

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment 👍

@The-Compiler
Copy link
Member Author

Sounds good as long as GitHub still picks it up as well. @nicoddemus if you have the time, could you maybe pick this up? I'm quite busy with exams so I can't commit to continuing working on this until next month.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good! Thanks for this

@nicoddemus
Copy link
Member

Hmmm oh right: https://help.github.com/en/articles/adding-a-code-of-conduct-to-your-project

It seems it only supports .md. Well in that case I suppose we can close this, as it will get enough visibility by GitHub's own means (issues and PRs).

@nicoddemus nicoddemus merged commit 5ecac3c into master Aug 8, 2019
@nicoddemus nicoddemus deleted the coc branch August 8, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants