Skip to content

Conversation

@graingert
Copy link
Member

@graingert graingert commented Aug 6, 2019

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order;

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #5703 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   96.16%   96.17%   +<.01%     
==========================================
  Files         117      117              
  Lines       25864    25864              
  Branches     2498     2498              
==========================================
+ Hits        24873    24875       +2     
+ Misses        690      689       -1     
+ Partials      301      300       -1
Impacted Files Coverage Δ
testing/python/collect.py 99.36% <ø> (ø) ⬆️
src/_pytest/pastebin.py 91.22% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c486a...ef0915e. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is, thanks!

@nicoddemus nicoddemus merged commit 28fabc5 into master Aug 6, 2019
@nicoddemus nicoddemus deleted the graingert-patch-2 branch August 6, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants