Skip to content

Fix RuntimeError when trying to collect package with "__init__.py" only #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2019
Merged

Fix RuntimeError when trying to collect package with "__init__.py" only #5697

merged 1 commit into from
Aug 5, 2019

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 5, 2019

Fixes #4344.

@blueyed blueyed mentioned this pull request Aug 5, 2019
Closed
4 tasks
nicoddemus
nicoddemus approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited
Loading

Codecov Report

Merging #5697 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
- Coverage   96.17%   96.15%   -0.03%     
==========================================
  Files         117      117              
  Lines       25853    25864      +11     
  Branches     2498     2498              
==========================================
+ Hits        24864    24869       +5     
- Misses        689      695       +6     
  Partials      300      300
Impacted Files Coverage Δ
src/_pytest/main.py 96.93% <100%> (+0.02%) ⬆️
testing/test_collection.py 99.81% <100%> (ø) ⬆️
src/_pytest/doctest.py 94.38% <0%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a66a50...198fcd8. Read the comment docs.

@blueyed blueyed merged commit bf3aa72 into pytest-dev:master Aug 5, 2019
@blueyed blueyed deleted the fix-collect-pkg-init branch August 5, 2019 16:20
@blueyed
Copy link
Contributor Author

blueyed commented Aug 5, 2019

Will do the backport.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 5, 2019

Meant to create a PR, but pushed it accidentally already: b71f873.

@asottile asottile added backported and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StopIteration error in CircleCI using split tests pattern

3 participants

@blueyed @nicoddemus @asottile