Skip to content

Conversation

@asottile
Copy link
Member

No description provided.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

img

comment to `#5402 <https://github.com/pytest-dev/pytest/issues/5402>`__.


- `#5412 <https://github.com/pytest-dev/pytest/issues/5412>`_: ``ExceptionInfo`` objects (returned by ``pytest.raises``) now have the same ``str`` representation as ``repr``, which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not for this release, random thought)

I'm thinking of adding a "Changes" to incorporate changes like this one: it is not a removal, merely a change in behavior which can potentially break existing suites. Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah seems fair to split it out -- I use a separate "Updating" section for pre-commit's changelogs: https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md#updating

@asottile
Copy link
Member Author

@nicoddemus alright, this should be ready again :D

@nicoddemus
Copy link
Member

Awesome, ship it! 😁 🎉

@asottile asottile merged commit 2c6453c into pytest-dev:master Jun 29, 2019
@asottile asottile deleted the release-5.0.0 branch June 29, 2019 01:12
@nicoddemus
Copy link
Member

Don't forget to send the announcement email 😉

@asottile
Copy link
Member Author

yep :) just did that!

@nicoddemus
Copy link
Member

email? Weird still have not gotten it...

@asottile
Copy link
Member Author

weird!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants