-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
WIP Preparing release version 5.0.0 #5500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| INTERNALERROR> spec = importlib.util.find_spec(x) | ||
| INTERNALERROR> File "$PYTHON_PREFIX/lib/python3.6/importlib/util.py", line 89, in find_spec | ||
| INTERNALERROR> return _find_spec(fullname, parent.__path__) | ||
| INTERNALERROR> AttributeError: module 'pythoncollection' has no attribute '__path__' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... weird. Any ideas @asottile? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I'll look at this when I'm at a computer. Seems bad, lol (almost certainly a quirk with the pyargs code, which probably has fewer tests than it needs)
Codecov Report
@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 96.07% 96.04% -0.04%
==========================================
Files 117 117
Lines 25646 25646
Branches 2484 2484
==========================================
- Hits 24640 24631 -9
- Misses 700 706 +6
- Partials 306 309 +3
Continue to review full report at Codecov.
|
|
Here is the minimal reproduction, I'll work on getting a fix for this: touch conftest.py t.py && pytest --pyargs t.pyIt's interpreting |
| * Victor Maryama | ||
| * Yuri Apollov | ||
| * Zac Hatfield-Dodds | ||
| * Zac-HD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I have some bad git metadata somewhere 😕 - we can delete this line.
|
#5503 fixes the INTERNALERROR |
No description provided.