Skip to content

Conversation

@nicoddemus
Copy link
Member

No description provided.

INTERNALERROR> spec = importlib.util.find_spec(x)
INTERNALERROR> File "$PYTHON_PREFIX/lib/python3.6/importlib/util.py", line 89, in find_spec
INTERNALERROR> return _find_spec(fullname, parent.__path__)
INTERNALERROR> AttributeError: module 'pythoncollection' has no attribute '__path__'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... weird. Any ideas @asottile? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I'll look at this when I'm at a computer. Seems bad, lol (almost certainly a quirk with the pyargs code, which probably has fewer tests than it needs)

@nicoddemus nicoddemus changed the title Preparing release version 5.0.0 WIP Preparing release version 5.0.0 Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #5500 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
- Coverage   96.07%   96.04%   -0.04%     
==========================================
  Files         117      117              
  Lines       25646    25646              
  Branches     2484     2484              
==========================================
- Hits        24640    24631       -9     
- Misses        700      706       +6     
- Partials      306      309       +3
Impacted Files Coverage Δ
src/_pytest/assertion/util.py 92.36% <0%> (-2.68%) ⬇️
src/_pytest/doctest.py 95.16% <0%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fb50a...068fb2c. Read the comment docs.

@asottile
Copy link
Member

Here is the minimal reproduction, I'll work on getting a fix for this:

touch conftest.py t.py && pytest --pyargs t.py

It's interpreting t.py as a module and then trying to import t.py (which rightfully errors)

* Victor Maryama
* Yuri Apollov
* Zac Hatfield-Dodds
* Zac-HD
Copy link
Member

@Zac-HD Zac-HD Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I have some bad git metadata somewhere 😕 - we can delete this line.

@asottile
Copy link
Member

#5503 fixes the INTERNALERROR

@nicoddemus nicoddemus closed this Jun 27, 2019
@nicoddemus nicoddemus deleted the release-5.0.0 branch June 27, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants