Deprecate funcargnames alias for fixturenames #5476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## features #5476 +/- ##
============================================
- Coverage 83.14% 82.93% -0.21%
============================================
Files 114 114
Lines 25528 25532 +4
Branches 2482 2482
============================================
- Hits 21224 21176 -48
- Misses 3915 3948 +33
- Partials 389 408 +19
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Jun 24, 2019
Zac-HD
force-pushed
the
funcargnames-to-fixturenames
branch
2 times, most recently
from
d6258f9 to
d4b9e5f
Compare
Zac-HD
changed the title
nicoddemus
requested changes
Jun 25, 2019
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Looks great, just missing the CHANGELOG.
Please also update deprecations.rst with a new section. 👍
Zac-HD
force-pushed
the
funcargnames-to-fixturenames
branch
from
1bf136d to
138cdcf
Compare
nicoddemus
approved these changes
Jun 25, 2019
|
|
||
| .. deprecated:: 5.0 | ||
|
|
||
| The ``FixtureRequest``, ``Metafunc``, and ``Function`` classes track the names of |
Member
Author
|
OK! I'm going to close this, and re-target it against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But leave the helper until 5.1, so that the error message can be helpful and suggest using the modern form. Closes #4676.
I've gone with a hardAttributeErrorover a warning because it's a trivial and far-back-compatible thing to fix, and it would be really nice to delete theFuncargnamesCompatAttrclass in 5.1.