Skip to content

item.obj is again a bound method on TestCase function items #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

item.obj is again a bound method on TestCase function items #5393

merged 1 commit into from
Jun 5, 2019

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jun 4, 2019

Fix #5390

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 4, 2019
@nicoddemus nicoddemus mentioned this pull request Jun 4, 2019
Closed
blueyed
blueyed reviewed Jun 4, 2019
View reviewed changes
blueyed
blueyed reviewed Jun 4, 2019
View reviewed changes
@nicoddemus nicoddemus force-pushed the unittest-self-5390 branch from b20772d to 4c6619b Compare June 4, 2019 23:20
@codecov
Copy link

codecov bot commented Jun 4, 2019 •
edited
Loading

Codecov Report

Merging #5393 into master will decrease coverage by 2.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
- Coverage   92.71%   89.99%   -2.73%     
==========================================
  Files         114      114              
  Lines       25493    25654     +161     
  Branches     2480     2492      +12     
==========================================
- Hits        23637    23088     -549     
- Misses       1529     2233     +704     
- Partials      327      333       +6
Impacted Files Coverage Δ
src/_pytest/unittest.py 94.97% <100%> (+1.18%) ⬆️
testing/test_unittest.py 99.08% <100%> (+0.02%) ⬆️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/test_session.py 16.12% <0%> (-83.88%) ⬇️
testing/test_runner_xunit.py 24.52% <0%> (-75.48%) ⬇️
testing/test_runner.py 33.99% <0%> (-62.29%) ⬇️
testing/test_resultlog.py 52.45% <0%> (-47.55%) ⬇️
testing/test_pytester.py 54.7% <0%> (-34.76%) ⬇️
src/_pytest/reports.py 68.81% <0%> (-26.24%) ⬇️
testing/test_skipping.py 72.41% <0%> (-25.58%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d5080...1f8fd42. Read the comment docs.

@nicoddemus nicoddemus force-pushed the unittest-self-5390 branch from 4c6619b to 1f8fd42 Compare June 4, 2019 23:22
asottile
asottile approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 0f4992c into pytest-dev:master Jun 5, 2019
@asottile
Copy link
Member

asottile commented Jun 5, 2019

backport: #5399

@nicoddemus nicoddemus deleted the unittest-self-5390 branch June 5, 2019 01:27
nicoddemus added a commit that referenced this pull request Jun 5, 2019
@nicoddemus
[4.6] Merge pull request #5393 from nicoddemus/unittest-self-5390 (#5399
8076f48 
)

[4.6] Merge pull request #5393 from nicoddemus/unittest-self-5390
@asottile asottile added backported and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

+1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pytest 4.2.0 unittest.TestCase can no longer access parent instance

3 participants

@nicoddemus @asottile @blueyed