Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 3, 2019

Reverts #5377

Shouldn't be necessary with the unrolling of all being removed... - and might serve as an indication when trying to get it in again (since this started failing with it).

@blueyed blueyed changed the title Revert "Revert "Revert "ci: Travis: add pypy3 to allowed failures temporarily""" Revert "ci: Travis: add pypy3 to allowed failures temporarily" Jun 3, 2019
@blueyed blueyed self-assigned this Jun 3, 2019
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #5378 into master will increase coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5378     +/-   ##
=========================================
+ Coverage   93.33%   94.64%   +1.3%     
=========================================
  Files         114      114             
  Lines       25493    25493             
  Branches     2480     2480             
=========================================
+ Hits        23795    24128    +333     
+ Misses       1379     1048    -331     
+ Partials      319      317      -2
Impacted Files Coverage Δ
testing/python/fixtures.py 86.47% <0%> (-4.1%) ⬇️
src/_pytest/python.py 91.32% <0%> (-0.86%) ⬇️
src/_pytest/nodes.py 95% <0%> (-0.5%) ⬇️
src/_pytest/main.py 95.98% <0%> (-0.24%) ⬇️
testing/test_recwarn.py 99.57% <0%> (+2.57%) ⬆️
src/_pytest/pytester.py 90.59% <0%> (+3.47%) ⬆️
src/_pytest/tmpdir.py 100% <0%> (+3.7%) ⬆️
testing/test_terminal.py 99.53% <0%> (+5.94%) ⬆️
testing/python/metafunc.py 87.73% <0%> (+9.71%) ⬆️
testing/python/setup_only.py 100% <0%> (+19.64%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8b082...606d728. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #5378 into master will increase coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5378     +/-   ##
=========================================
+ Coverage   93.33%   94.64%   +1.3%     
=========================================
  Files         114      114             
  Lines       25493    25493             
  Branches     2480     2480             
=========================================
+ Hits        23795    24128    +333     
+ Misses       1379     1048    -331     
+ Partials      319      317      -2
Impacted Files Coverage Δ
testing/python/fixtures.py 86.47% <0%> (-4.1%) ⬇️
src/_pytest/python.py 91.32% <0%> (-0.86%) ⬇️
src/_pytest/nodes.py 95% <0%> (-0.5%) ⬇️
src/_pytest/main.py 95.98% <0%> (-0.24%) ⬇️
testing/test_recwarn.py 99.57% <0%> (+2.57%) ⬆️
src/_pytest/pytester.py 90.59% <0%> (+3.47%) ⬆️
src/_pytest/tmpdir.py 100% <0%> (+3.7%) ⬆️
testing/test_terminal.py 99.53% <0%> (+5.94%) ⬆️
testing/python/metafunc.py 87.73% <0%> (+9.71%) ⬆️
testing/python/setup_only.py 100% <0%> (+19.64%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8b082...606d728. Read the comment docs.

@nicoddemus nicoddemus merged commit 2cfd9c2 into master Jun 3, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Jun 4, 2019

I had assigned this to me, because I wanted to investigate / verify that this is OK.
Which does not appear to be the case: https://travis-ci.org/pytest-dev/pytest/builds/541022238

@blueyed blueyed deleted the revert-5377-pypy3 branch June 4, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants