Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jun 1, 2019

  • Target the master branch for bug fixes, documentation updates and trivial changes.

@hugovk hugovk added the type: docs documentation improvement, missing or needing clarification label Jun 1, 2019
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #5355 into master will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5355      +/-   ##
=========================================
- Coverage   95.32%   94.3%   -1.02%     
=========================================
  Files         115     115              
  Lines       26384   26384              
  Branches     2607    2607              
=========================================
- Hits        25150   24881     -269     
- Misses        924    1187     +263     
- Partials      310     316       +6
Impacted Files Coverage Δ
testing/test_warnings.py 41.53% <0%> (-54.1%) ⬇️
testing/test_reports.py 56.9% <0%> (-43.1%) ⬇️
testing/test_pytester.py 55.21% <0%> (-34.09%) ⬇️
testing/test_pluginmanager.py 49.57% <0%> (-4.67%) ⬇️
src/_pytest/pytester.py 86.86% <0%> (-2.97%) ⬇️
src/_pytest/reports.py 92.11% <0%> (-2.96%) ⬇️
testing/test_recwarn.py 97.03% <0%> (-2.55%) ⬇️
src/_pytest/main.py 96.06% <0%> (+0.21%) ⬆️
testing/python/fixtures.py 98.52% <0%> (+8.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917195e...e2ac4b7. Read the comment docs.

@nicoddemus nicoddemus merged commit a8f4e56 into master Jun 1, 2019
@nicoddemus nicoddemus deleted the 🛠🔗⚓ branch June 1, 2019 22:09
@nicoddemus
Copy link
Member

Thanks @hugovk!

@asottile
Copy link
Member

asottile commented Jun 1, 2019

@nicoddemus should we backport this? or is it less important that the 4.6.x docs are perfectly up to date?

@nicoddemus
Copy link
Member

nicoddemus commented Jun 1, 2019

is it less important that the 4.6.x docs are perfectly up to date?

It is, I don't think we will publish separate docs for the 4.6.X series: new 5.0+ features will be marked clearly as such, same as we have been doing with the previous releases. What do you think?

@asottile
Copy link
Member

asottile commented Jun 1, 2019

sg2m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs documentation improvement, missing or needing clarification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants