Skip to content

Conversation

@lsnk
Copy link
Contributor

@lsnk lsnk commented May 16, 2019

Do i really need to create issue and changelog record for such a small fix?

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #5273 into master will decrease coverage by 3.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5273      +/-   ##
==========================================
- Coverage   91.64%   88.18%   -3.46%     
==========================================
  Files         115      115              
  Lines       26163    26163              
  Branches     2578     2578              
==========================================
- Hits        23977    23073     -904     
- Misses       1864     2728     +864     
- Partials      322      362      +40
Impacted Files Coverage Δ
testing/python/collect.py 23.66% <0%> (-64.18%) ⬇️
testing/python/fixtures.py 62.08% <0%> (-35.06%) ⬇️
testing/test_terminal.py 74.18% <0%> (-23.02%) ⬇️
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
testing/python/setup_only.py 92.85% <0%> (-7.15%) ⬇️
testing/python/raises.py 88.51% <0%> (-6.09%) ⬇️
src/_pytest/compat.py 91.95% <0%> (-5.03%) ⬇️
testing/python/metafunc.py 88.05% <0%> (-4.05%) ⬇️
testing/test_tmpdir.py 95.16% <0%> (-3.77%) ⬇️
testing/deprecated_test.py 96.77% <0%> (-3.23%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9642427...858010e. Read the comment docs.

@nicoddemus
Copy link
Member

Hi @lsnk, thanks for the contribution!

Do i really need to create issue and changelog record for such a small fix?

No, but you are right we should improve our template to make that explicit. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants