Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 4, 2019

According to https://codecov.io/gh/pytest-dev/pytest/pull/4881/changes
the "isatty" branches in _pytest/terminal.py are flaky.

This tries to fix it.

Maybe running it in a subprocess would also help, but it might be more about the outer term in the first place.

Travis should behave as a TTY AFAIK.

blueyed added 3 commits March 4, 2019 18:08
According to https://codecov.io/gh/pytest-dev/pytest/pull/4881/changes
the "isatty" branches in _pytest/terminal.py are flaky.

This tries to fix it.
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #4884 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4884      +/-   ##
==========================================
+ Coverage   94.47%   94.53%   +0.06%     
==========================================
  Files         113      113              
  Lines       25173    25173              
  Branches     2499     2499              
==========================================
+ Hits        23782    23798      +16     
+ Misses       1060     1048      -12     
+ Partials      331      327       -4
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.74% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb16a1...042f61e. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Mar 5, 2019

Also increased/covered without.

@blueyed blueyed closed this Mar 5, 2019
@blueyed blueyed deleted the travis-tty branch March 5, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant