Skip to content

Add config for isort #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

Add config for isort #4864

merged 2 commits into from
Mar 1, 2019

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 1, 2019

@blueyed
Copy link
Contributor Author

blueyed commented Mar 1, 2019

Canceled Travis manually.
Should be good.

nicoddemus
nicoddemus reviewed Mar 1, 2019
View reviewed changes
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Mar 1, 2019

We ought to use reorder-imports

@blueyed
Copy link
Contributor Author

blueyed commented Mar 1, 2019

We ought to use reorder-imports

We still do.

@nicoddemus
Copy link
Member

nicoddemus commented Mar 1, 2019

@RonnyPfannschmidt, @blueyed asked to add this because he uses vim and the isort plugin, and would like to improve his workflow personally. reorder-imports is still the single source of truth in the end, of course.

@blueyed
Copy link
Contributor Author

blueyed commented Mar 1, 2019

Please approve - I will merge it later then.
Can also pull out the whitespace changes if you like, but I think it is good.

@nicoddemus
Copy link
Member

nicoddemus commented Mar 1, 2019

Can also pull out the whitespace changes if you like, but I think it is good.

They are just a few and they are fine. 👍

@blueyed blueyed changed the title Add config for isort [merge later] Add config for isort Mar 1, 2019
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying,

@blueyed blueyed merged commit 4290cac into pytest-dev:master Mar 1, 2019
@blueyed blueyed deleted the isort-cfg branch March 1, 2019 17:45
@blueyed blueyed changed the title [merge later] Add config for isort Add config for isort Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blueyed @RonnyPfannschmidt @nicoddemus