-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix test_argcomplete: use python -m pytest #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4848 +/- ##
==========================================
+ Coverage 94.25% 94.35% +0.09%
==========================================
Files 113 113
Lines 25163 25160 -3
Branches 2498 2497 -1
==========================================
+ Hits 23718 23739 +21
+ Misses 1107 1088 -19
+ Partials 338 333 -5
Continue to review full report at Codecov.
|
|
Hmm, Travis does not run for draft PRs, but Azure does.. |
Hmmm can't we install
"trial" because it tests the "twisted trial" functionality, which is the builtin facilities to test "twisted" applications. I agree it is strange, I believe it would be better to rename to |
|
Now that I think about it, why we don't just install |
|
Sounds good, will do. |
Just test/install this with all envs. Ref: pytest-dev#4848 (comment)
Previously it was not run with a) xdist ("-c"), and b) "python -m
pytest" ("…/pytest.py", not executable).
71ac76f to
ccab469
Compare
Previously it was not run with a) xdist ("-c"), and b) "python -m
pytest" ("…/pytest.py", not executable).
We still need an env to acutally have argcomplete installed.
Where should it go?
Thought about
py27-trial(what does trial stand for there?), but it appears to only runtest_unittests?!