Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 27, 2019

Previously it was not run with a) xdist ("-c"), and b) "python -m
pytest" ("…/pytest.py", not executable).

We still need an env to acutally have argcomplete installed.

Where should it go?
Thought about py27-trial (what does trial stand for there?), but it appears to only run test_unittests?!

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #4848 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4848      +/-   ##
==========================================
+ Coverage   94.25%   94.35%   +0.09%     
==========================================
  Files         113      113              
  Lines       25163    25160       -3     
  Branches     2498     2497       -1     
==========================================
+ Hits        23718    23739      +21     
+ Misses       1107     1088      -19     
+ Partials      338      333       -5
Flag Coverage Δ
#linux 91.75% <50%> (+0.08%) ⬆️
#windows 93.46% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
testing/test_parseopt.py 97.97% <100%> (+3.17%) ⬆️
src/_pytest/terminal.py 91.74% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e711a6c...ccab469. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

Hmm, Travis does not run for draft PRs, but Azure does..

@nicoddemus
Copy link
Member

Where should it go?

Hmmm can't we install argcomplete in every environment, like we do with hypothesis and mock? Seems like it shouldn't be a big dependency.

Thought about py27-trial (what does trial stand for there?), but it appears to only run test_unittests?!

"trial" because it tests the "twisted trial" functionality, which is the builtin facilities to test "twisted" applications. I agree it is strange, I believe it would be better to rename to py27-twisted instead.

@nicoddemus
Copy link
Member

Now that I think about it, why we don't just install numpy and twisted in every environment as well? I think the cost of doing that would greatly offset the extra jobs we have just for those dependencies, specially with wheels available for numpy (which I suspect was the cause for splitting those environments in the first place).

@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

Sounds good, will do.

blueyed added a commit to blueyed/pytest that referenced this pull request Feb 27, 2019
Just test/install this with all envs.

Ref: pytest-dev#4848 (comment)
Previously it was not run with a) xdist ("-c"), and b) "python -m
pytest" ("…/pytest.py", not executable).
@blueyed blueyed force-pushed the fix-test_argcomplete branch from 71ac76f to ccab469 Compare February 27, 2019 15:52
@blueyed blueyed marked this pull request as ready for review February 27, 2019 15:52
@blueyed blueyed requested a review from nicoddemus February 27, 2019 16:50
@nicoddemus nicoddemus merged commit 55b78ff into pytest-dev:master Feb 27, 2019
@blueyed blueyed deleted the fix-test_argcomplete branch February 27, 2019 17:12
blueyed added a commit to blueyed/pytest that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants