-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Upload code coverage from azure #4831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db76ff8 to
fda9ab2
Compare
|
/AzurePipelines run pytest-CI |
fda9ab2 to
af38ef5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4831 +/- ##
==========================================
+ Coverage 95.48% 95.68% +0.19%
==========================================
Files 113 113
Lines 25163 25163
Branches 2498 2498
==========================================
+ Hits 24026 24076 +50
+ Misses 803 771 -32
+ Partials 334 316 -18
Continue to review full report at Codecov.
|
|
Hmmm realized that we need to skip coverage for |
af38ef5 to
5494eb1
Compare
|
Ready for review. Hmm bummer, build time jumped from 15m to 30m because of coverage. 😞 But of course, much faster than AppVeyor. 👍 |
| - script: call scripts\upload-coverage.bat | ||
| displayName: 'Upload coverage' | ||
| env: | ||
| CODECOV_TOKEN: $(CODECOV_TOKEN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CODECOV_TOKEN configured through their UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, as a secret variable. 👍
|
@blueyed I'm not sure the flags adjustment to codecov helped, the |
|
@nicoddemus |
|
The commit itself can be seen on https://codecov.io/gh/pytest-dev/pytest/tree/5494eb1948351d44ff58288dcfc500d1a584aed6 - but is not having the "Changes". Those are due to skipping Linux/MacOS/Travis though likely, no? |
|
I'll go ahead and amend this. |
5494eb1 to
d5d1903
Compare
Right, most likely.
OK, thanks! |
|
@nicoddemus |
|
Yeah not sure how much |
No description provided.