Skip to content

Conversation

@nicoddemus
Copy link
Member

No description provided.

@nicoddemus nicoddemus requested a review from blueyed February 25, 2019 23:29
@nicoddemus nicoddemus force-pushed the codocov-azure branch 3 times, most recently from db76ff8 to fda9ab2 Compare February 26, 2019 00:02
@nicoddemus
Copy link
Member Author

/AzurePipelines run pytest-CI

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #4831 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4831      +/-   ##
==========================================
+ Coverage   95.48%   95.68%   +0.19%     
==========================================
  Files         113      113              
  Lines       25163    25163              
  Branches     2498     2498              
==========================================
+ Hits        24026    24076      +50     
+ Misses        803      771      -32     
+ Partials      334      316      -18
Flag Coverage Δ
#linux 95.45% <ø> (ø) ⬆️
#osx 93.29% <ø> (ø) ⬆️
#windows 93.72% <ø> (?)
Impacted Files Coverage Δ
src/_pytest/fixtures.py 97.91% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.23% <0%> (+0.3%) ⬆️
src/_pytest/pytester.py 87.05% <0%> (+0.42%) ⬆️
src/_pytest/nodes.py 95.52% <0%> (+0.99%) ⬆️
src/_pytest/config/findpaths.py 95% <0%> (+1%) ⬆️
testing/acceptance_test.py 97.85% <0%> (+1.07%) ⬆️
src/_pytest/junitxml.py 95.84% <0%> (+1.27%) ⬆️
src/_pytest/cacheprovider.py 97.16% <0%> (+1.41%) ⬆️
src/_pytest/pathlib.py 90.65% <0%> (+2.19%) ⬆️
src/_pytest/capture.py 94.11% <0%> (+3.16%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7428064...d5d1903. Read the comment docs.

@nicoddemus
Copy link
Member Author

Hmmm realized that we need to skip coverage for pypy because it is way too slow. It has been running now for 30m, and only reached 60% of the tests. 😓

@nicoddemus nicoddemus changed the title Upload code coverage from azure WIP Upload code coverage from azure Feb 26, 2019
@nicoddemus nicoddemus changed the title WIP Upload code coverage from azure Upload code coverage from azure Feb 26, 2019
@nicoddemus
Copy link
Member Author

nicoddemus commented Feb 26, 2019

Ready for review.

Hmm bummer, build time jumped from 15m to 30m because of coverage. 😞

But of course, much faster than AppVeyor. 👍

- script: call scripts\upload-coverage.bat
displayName: 'Upload coverage'
env:
CODECOV_TOKEN: $(CODECOV_TOKEN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CODECOV_TOKEN configured through their UI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as a secret variable. 👍

@nicoddemus
Copy link
Member Author

@blueyed I'm not sure the flags adjustment to codecov helped, the codecov/project check is still timing out for me. 😞

@blueyed
Copy link
Contributor

blueyed commented Feb 26, 2019

@nicoddemus
too bad, sorry.
It is likely more/also related to the number of uploads (which we now have increased with azure).

@blueyed
Copy link
Contributor

blueyed commented Feb 26, 2019

The commit itself can be seen on https://codecov.io/gh/pytest-dev/pytest/tree/5494eb1948351d44ff58288dcfc500d1a584aed6 - but is not having the "Changes".

Those are due to skipping Linux/MacOS/Travis though likely, no?

@blueyed
Copy link
Contributor

blueyed commented Feb 26, 2019

I'll go ahead and amend this.

@nicoddemus
Copy link
Member Author

Those are due to skipping Linux/MacOS/Travis though likely, no?

Right, most likely.

I'll go ahead and amend this.

OK, thanks!

@nicoddemus nicoddemus merged commit ee62674 into pytest-dev:master Feb 26, 2019
@nicoddemus nicoddemus deleted the codocov-azure branch February 26, 2019 17:42
@blueyed
Copy link
Contributor

blueyed commented Feb 26, 2019

@nicoddemus
I think you want to drop AppVeyor completely soon now, but we should remove coverage reporting from it at least as soon as possible.

@nicoddemus
Copy link
Member Author

Yeah not sure how much py37-freeze is a blocker on Azure anyway. I will give it a shot later, and if I can't get it to work I think it is fine to just assume Azure officially and drop AppVeyor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants