Skip to content

Conversation

@nicoddemus
Copy link
Member

🎉

alysivji and others added 30 commits November 12, 2018 09:20
This allows to make use of it when determining the rootdir etc.
approx() was updated in 9f3122f to work better with numpy arrays,
however at the same time the requirements were tightened from
requiring an Iterable to requiring a Sequence - the former being
tested only on interface, while the latter requires subclassing or
registration with the abc.

Since the ApproxSequence only used __iter__ and __len__ this commit
reduces the requirement to only what's used, and allows unregistered
Sequence-like containers to be used.

Since numpy arrays qualify for the new criteria, reorder the checks so
that generic sequences are checked for after numpy arrays.
This handles `header` similar to Python 3.7 does it, and forwards any
other keyword arguments to the Pdb constructor.

This allows for `__import__("pdb").set_trace(skip=["foo.*"])`.

Fixes pytest-dev#4416.
…st-namespace

remove pytest namespace hook
This was documented before, but never enforced.  Passing non-strings could
have strange side-effects and enforcing a string simplifies other
implementation.
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this release is going to be exciting -- looks like attrs is in the changelog twice though

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #4600 into master will decrease coverage by 0.13%.
The diff coverage is 96.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4600      +/-   ##
==========================================
- Coverage   95.89%   95.75%   -0.14%     
==========================================
  Files         111      111              
  Lines       25123    24678     -445     
  Branches     2449     2446       -3     
==========================================
- Hits        24091    23630     -461     
- Misses        726      740      +14     
- Partials      306      308       +2
Flag Coverage Δ
#docs 29.57% <31.36%> (-0.42%) ⬇️
#doctesting 29.57% <31.36%> (-0.42%) ⬇️
#linting 29.57% <31.36%> (-0.42%) ⬇️
#linux 95.57% <95.98%> (-0.16%) ⬇️
#nobyte 92.37% <89.13%> (-0.31%) ⬇️
#numpy 93.19% <92.55%> (-0.26%) ⬇️
#pexpect 42.13% <42.22%> (+0.31%) ⬆️
#py27 93.79% <92.55%> (-0.25%) ⬇️
#py34 91.86% <88.54%> (-0.26%) ⬇️
#py35 91.88% <88.54%> (-0.26%) ⬇️
#py36 91.9% <88.54%> (-0.26%) ⬇️
#py37 93.9% <94.64%> (-0.21%) ⬇️
#trial 93.19% <92.55%> (-0.26%) ⬇️
#windows 93.94% <93.75%> (-0.2%) ⬇️
#xdist 93.79% <93.75%> (-0.19%) ⬇️
Impacted Files Coverage Δ
testing/test_runner_xunit.py 100% <ø> (ø) ⬆️
testing/test_nose.py 98.86% <ø> (-0.07%) ⬇️
src/pytest.py 100% <ø> (ø) ⬆️
testing/test_collection.py 99.79% <ø> (-0.01%) ⬇️
testing/test_skipping.py 98.68% <ø> (ø) ⬆️
src/_pytest/capture.py 93.66% <0%> (ø) ⬆️
testing/test_assertrewrite.py 83.46% <0%> (ø) ⬆️
testing/test_warnings.py 98.81% <100%> (+0.16%) ⬆️
testing/deprecated_test.py 100% <100%> (ø) ⬆️
testing/test_capture.py 99.24% <100%> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24fdb1...e24031f. Read the comment docs.

@s0undt3ch
Copy link
Contributor

🎉

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this time with emphasis ;)

@nicoddemus nicoddemus merged commit 38adb23 into pytest-dev:master Jan 6, 2019
@nicoddemus nicoddemus deleted the release-4.1.0 branch January 6, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants