Skip to content

Fix collection of testpaths with --pyargs #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2018
Merged

Fix collection of testpaths with --pyargs #4411

merged 1 commit into from
Nov 17, 2018

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 17, 2018

Fixes #4405.

@blueyed blueyed added type: bug problem that needs to be addressed topic: collection related to the collection phase labels Nov 17, 2018
@blueyed blueyed mentioned this pull request Nov 17, 2018
Closed
@blueyed blueyed merged commit 4c9cde7 into pytest-dev:master Nov 17, 2018
@blueyed blueyed deleted the fix-testpaths-with-pyargs branch November 17, 2018 16:20
@hroncok
Copy link
Member

hroncok commented Mar 12, 2019

For the record, this causes a regression when running the tests with custom PYTHONPATH: #4913

A fix is ready at #4914 and I've requested a review from @blueyed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees

No one assigned

Labels

topic: collection related to the collection phase type: bug problem that needs to be addressed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blueyed @hroncok @RonnyPfannschmidt