Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 10, 2018

No description provided.

@blueyed blueyed added type: enhancement new feature or API change, should be merged into features branch type: infrastructure improvement to development/releases/CI structure labels Nov 10, 2018
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #4365 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4365      +/-   ##
==========================================
- Coverage   95.85%   95.64%   -0.22%     
==========================================
  Files         111      111              
  Lines       24910    24910              
  Branches     2431     2431              
==========================================
- Hits        23877    23824      -53     
- Misses        736      774      +38     
- Partials      297      312      +15
Flag Coverage Δ
#docs ?
#doctesting ?
#linting ?
#linux 95.64% <ø> (ø) ⬆️
#nobyte 91.22% <ø> (-0.64%) ⬇️
#numpy 41.62% <ø> (-51.39%) ⬇️
#pexpect 41.62% <ø> (ø) ⬆️
#py27 93.9% <ø> (-0.13%) ⬇️
#py34 92.03% <ø> (-0.07%) ⬇️
#py35 92.04% <ø> (-0.07%) ⬇️
#py36 93.75% <ø> (-0.15%) ⬇️
#py37 92.21% <ø> (+0.06%) ⬆️
#trial 41.62% <ø> (-51.39%) ⬇️
#windows ?
#xdist 93.58% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
src/_pytest/assertion/util.py 92.92% <0%> (-5.19%) ⬇️
testing/test_tmpdir.py 94.33% <0%> (-4.41%) ⬇️
src/_pytest/capture.py 90.7% <0%> (-3.18%) ⬇️
src/_pytest/pathlib.py 88.46% <0%> (-2.2%) ⬇️
testing/acceptance_test.py 97.2% <0%> (-1.08%) ⬇️
src/_pytest/nodes.py 93.95% <0%> (-0.81%) ⬇️
src/_pytest/pytester.py 86.96% <0%> (-0.43%) ⬇️
testing/test_capture.py 98.92% <0%> (-0.31%) ⬇️
src/_pytest/fixtures.py 97.13% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab3d81...dc9ceda. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Nov 11, 2018

@nicoddemus
Please merge if it is OK.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @blueyed!

@nicoddemus nicoddemus merged commit 11a9cbd into pytest-dev:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement new feature or API change, should be merged into features branch type: infrastructure improvement to development/releases/CI structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants