Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 9, 2018

Ref: #4127

@blueyed
Copy link
Contributor Author

blueyed commented Nov 9, 2018

Feel free to comment, but let's go with #4358 first.

@blueyed blueyed closed this Nov 9, 2018
@blueyed blueyed deleted the remove-instance branch November 9, 2018 10:12
@nicoddemus
Copy link
Member

Just to note that this is breaking change as pytest.Instance is part of the API. We should figure out a way to deprecate its access somehow if we are to delete it in the future.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus this is one of the changes where i want to do a breaking release without the ramp ups

@nicoddemus
Copy link
Member

Without the ramp ups because there's no sane way to generate a warning for this, correct? I agree, I can't think of a portable way to issue that warning either.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants