[WIP/later] collection: cleanup/centralize keepduplicates handling #4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
added
type: enhancement
blueyed
commented
Nov 7, 2018
| (type(node), hello) | ||
| } | ||
| node.session.config.pluginmanager._duplicatepaths = set() | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Will losen that a bit, but still wonder if that's expected/sane.
diff --git a/testing/test_collection.py b/testing/test_collection.py
index 659d39c8..fbc8cc7b 100644
--- a/testing/test_collection.py
+++ b/testing/test_collection.py
@@ -101,9 +101,7 @@ def pytest_collect_file(path, parent):
# HACK: unset _duplicatepaths, which appears to be necessary for this
# specific test setup?!
- assert node.session.config.pluginmanager._duplicatepaths == {
- (type(node), hello)
- }
+ assert len(node.session.config.pluginmanager._duplicatepaths) == 1It is likely due to this specific test setup, right? (also causes #4331)
blueyed
changed the title
Contributor
Author
|
Does not fly by itself - will go back to other collection improvements first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.