Apply reorder-python-imports to all files #4235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| from __future__ import absolute_import, division, print_function | ||
| import sys | ||
| from __future__ import absolute_import |
Member
There was a problem hiding this comment.
@asottile can you change the tool so for future imports it does one line?
Member
Author
There was a problem hiding this comment.
nope, not configurable intentionally
asottile
commented
Oct 25, 2018
| rev: v1.3.2 | ||
| hooks: | ||
| - id: reorder-python-imports | ||
| args: ['--application-directories=.:src'] |
Member
Author
There was a problem hiding this comment.
I should probably also set --add-import 'from __future__ import absolute_import' and/or the others we want to enforce on all files
RonnyPfannschmidt
approved these changes
Oct 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #4235 +/- ##
==========================================
+ Coverage 95.82% 95.87% +0.05%
==========================================
Files 109 109
Lines 24286 24590 +304
Branches 2392 2392
==========================================
+ Hits 23271 23575 +304
Misses 720 720
Partials 295 295
Continue to review full report at Codecov.
|
nicoddemus
approved these changes
Oct 25, 2018
nicoddemus
added a commit
that referenced
this pull request
Oct 25, 2018
Add a changelog for #4235 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ah shoot, I should write a changelog entry -- maybe tomorrow
Resolves #4233