tests: fixes for pdbpp #4110
Merged
tests: fixes for pdbpp #4110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expect()` expects an regular expression, so "Pdb" is equivalent to "(Pdb)". But instead of escaping the parenthesis this patch removes them, to allow for matching "(Pdb++)", too.
With pdb++ this additional `expect` is required, otherwise `sendeof()` will block forever.
nicoddemus
approved these changes
Oct 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #4110 +/- ##
==========================================
+ Coverage 94.5% 94.53% +0.03%
==========================================
Files 109 109
Lines 23810 23813 +3
Branches 2349 2349
==========================================
+ Hits 22502 22512 +10
+ Misses 1000 997 -3
+ Partials 308 304 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/antocuni/pdb