Skip to content

Conversation

@njqdev
Copy link
Contributor

@njqdev njqdev commented Oct 10, 2018

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

@njqdev
Copy link
Contributor Author

njqdev commented Oct 10, 2018

#4093
Fixed the incorrect string literals, not black

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njonesu! Fixed linting and then it should be ready for merging. 👍

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #4109 into master will decrease coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4109      +/-   ##
==========================================
- Coverage    94.5%   94.45%   -0.05%     
==========================================
  Files         109      109              
  Lines       23810    23805       -5     
  Branches     2349     2346       -3     
==========================================
- Hits        22502    22486      -16     
- Misses       1000     1006       +6     
- Partials      308      313       +5
Flag Coverage Δ
#doctesting ?
#linux 93.56% <75%> (-0.8%) ⬇️
#nobyte ?
#numpy 27.41% <0%> (-0.68%) ⬇️
#pexpect ?
#py27 92.12% <75%> (-0.51%) ⬇️
#py34 92.12% <75%> (+0.03%) ⬆️
#py35 91.49% <75%> (-0.61%) ⬇️
#py36 92.16% <75%> (-0.51%) ⬇️
#py37 91.67% <75%> (-0.64%) ⬇️
#trial 30.39% <0%> (-0.93%) ⬇️
#windows 93.8% <75%> (ø) ⬆️
#xdist 18.1% <0%> (-0.46%) ⬇️
Impacted Files Coverage Δ
testing/acceptance_test.py 97.8% <ø> (ø) ⬆️
src/_pytest/helpconfig.py 85.04% <ø> (ø) ⬆️
src/_pytest/assertion/util.py 92.92% <ø> (-5.19%) ⬇️
testing/test_junitxml.py 96.09% <ø> (ø) ⬆️
src/_pytest/compat.py 96.62% <ø> (ø) ⬆️
src/_pytest/python.py 95.68% <ø> (ø) ⬆️
src/_pytest/terminal.py 91.27% <ø> (+1.39%) ⬆️
src/_pytest/deprecated.py 100% <ø> (ø) ⬆️
testing/test_pdb.py 53.13% <ø> (ø) ⬆️
src/_pytest/cacheprovider.py 96.92% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b164d9...c9a85b0. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 11, 2018

Coverage Status

Coverage increased (+0.02%) to 93.812% when pulling c9a85b0 on njonesu:master into 4b164d9 on pytest-dev:master.

@nicoddemus nicoddemus merged commit 0f5263c into pytest-dev:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants