-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix multiple string literals on a line #4093 #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
#4093 |
asottile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks!
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @njonesu! Fixed linting and then it should be ready for merging. 👍
Codecov Report
@@ Coverage Diff @@
## master #4109 +/- ##
==========================================
- Coverage 94.5% 94.45% -0.05%
==========================================
Files 109 109
Lines 23810 23805 -5
Branches 2349 2346 -3
==========================================
- Hits 22502 22486 -16
- Misses 1000 1006 +6
- Partials 308 313 +5
Continue to review full report at Codecov.
|
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;