Skip to content

Fix formatting for plugin loading in conftest #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix formatting for plugin loading in conftest #4097

merged 1 commit into from
Oct 9, 2018

Conversation

@asottile
Copy link
Member

@asottile asottile commented Oct 9, 2018 •
edited
Loading

what I did

  • The text in this section looked redundant so I removed the extra bits
  • I then changed the code to be a code block, then blacken-docs did the rest

comparison

(ignore the font differences, one is in a VM one is out)

before

after

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thanks 👍

nicoddemus
nicoddemus approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented Oct 9, 2018

Coverage Status

Coverage increased (+0.2%) to 93.812% when pulling aaaae0b on asottile:improve_doc_plugin_load into c55d641 on pytest-dev:master.

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 93.812% when pulling aaaae0b on asottile:improve_doc_plugin_load into c55d641 on pytest-dev:master.

@asottile asottile merged commit b8c30aa into pytest-dev:master Oct 9, 2018
@asottile asottile deleted the improve_doc_plugin_load branch October 9, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

@crazymerlyn crazymerlyn crazymerlyn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asottile @coveralls @RonnyPfannschmidt @nicoddemus @crazymerlyn