Skip to content

Fix request.fixturenames to return fixtures created dynamically #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Fix request.fixturenames to return fixtures created dynamically #4075

merged 1 commit into from
Oct 4, 2018

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Oct 3, 2018

Fix #3057

@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 93.813% when pulling 70c7273 on nicoddemus:dynamic-fixturenames into e712adc on pytest-dev:master.

asottile
asottile approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nicoddemus nicoddemus merged commit a1208f5 into pytest-dev:master Oct 4, 2018
@nicoddemus nicoddemus deleted the dynamic-fixturenames branch October 4, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @coveralls @asottile