Skip to content

Conversation

@beneyal
Copy link
Contributor

@beneyal beneyal commented Oct 2, 2018

Stumbled with that way more than I thought 😄
Fixes #4062 .

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @beneyal!

@RonnyPfannschmidt
Copy link
Member

remidns e, we need to deprecate it, it breaks entrypoint systems ^^ - all those freeze things are horribly broken and dont fix

@nicoddemus
Copy link
Member

remidns e, we need to deprecate it, it breaks entrypoint system

I disagree, it has worked perfectly well for years for us at ESSS (which is the use case presented in the docs).

@RonnyPfannschmidt
Copy link
Member

@nicoddemus the freezer things had years to fix the entrypoint system and they didnt, it makes it required to keep pytest internals on a legacy structure that uses plain python data instead of driving it by metadata

im not saying to remove it without having a alternative, but without a deprecation cycle its impossible to move it to a project that generates the supporting structures when its made

im happy to take part in architect something that can support pytest plugins in the long run, but for that, we still have to properly deprecate the hook

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.811% when pulling a5269b2 on beneyal:master into 25fe370 on pytest-dev:master.

@nicoddemus nicoddemus merged commit 20f93ae into pytest-dev:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants