Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 17, 2018

This should increase coverage for subprocesses, where source is used
only from the config file, but not the initial --source argument.

@blueyed blueyed force-pushed the coverage-source branch 2 times, most recently from 77887f0 to 615613d Compare September 17, 2018 11:41
@coveralls
Copy link

coveralls commented Sep 17, 2018

Coverage Status

Coverage increased (+0.03%) to 93.843% when pulling 28c9cc7 on blueyed:coverage-source into bb57186 on pytest-dev:master.

@blueyed blueyed changed the title coverage: use absolute paths in .coveragerc coverage: use modules Sep 17, 2018
@blueyed blueyed requested a review from nicoddemus September 17, 2018 20:57
@blueyed
Copy link
Contributor Author

blueyed commented Sep 17, 2018

I'm investigating codecov problems with them.
The project compare view (https://codecov.io/gh/pytest-dev/pytest/compare/bb57186dd4ad1bdf57ce05f41b8326a634741f23...2868b39d40945020097e6c08e10bd64b75c8017a) is still timing out on their side unfortunately, but would be required to see how this actually improves things.


[paths]
source = src/
.tox/*/lib/python*/site-packages/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This on Windows would be .tox\*e\Lib\site-packages. Can we add another entry here and coverage will try one and then the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added .tox\*e\Lib\site-packages\.

This gets used with coverage report - so you could test it after e.g. tox -e py36-coverage -- testing/deprecated_test.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! 🤗

This should increase coverage for subprocesses, where previously
`source` paths were used only from the config file, but not the initial
`--source` argument.
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #3990 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3990      +/-   ##
==========================================
+ Coverage   94.48%   94.53%   +0.04%     
==========================================
  Files         107      108       +1     
  Lines       23663    23686      +23     
  Branches     2349     2350       +1     
==========================================
+ Hits        22358    22391      +33     
+ Misses        994      988       -6     
+ Partials      311      307       -4
Flag Coverage Δ
#doctesting 29.41% <ø> (+0.15%) ⬆️
#linux 94.4% <ø> (+0.04%) ⬆️
#nobyte 0% <ø> (ø) ⬆️
#numpy 28.32% <ø> (+0.15%) ⬆️
#pexpect 0% <ø> (ø) ⬆️
#py27 92.64% <ø> (+0.04%) ⬆️
#py34 92.12% <ø> (+0.04%) ⬆️
#py35 92.13% <ø> (+0.04%) ⬆️
#py36 92.71% <ø> (+0.04%) ⬆️
#py37 92.34% <ø> (+0.04%) ⬆️
#trial 31.36% <ø> (+0.14%) ⬆️
#windows 93.86% <ø> (ø) ⬆️
#xdist 18.58% <ø> (+0.11%) ⬆️
Impacted Files Coverage Δ
src/pytest.py 100% <0%> (ø)
src/_pytest/terminal.py 91.6% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb57186...28c9cc7. Read the comment docs.

@nicoddemus nicoddemus merged commit 10b3b2d into pytest-dev:master Sep 19, 2018
@blueyed blueyed deleted the coverage-source branch September 20, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants