-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
coverage: use modules #3990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: use modules #3990
Conversation
77887f0 to
615613d
Compare
Faster to install and will retry uploads on connection errors.
615613d to
2868b39
Compare
|
I'm investigating codecov problems with them. |
|
|
||
| [paths] | ||
| source = src/ | ||
| .tox/*/lib/python*/site-packages/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This on Windows would be .tox\*e\Lib\site-packages. Can we add another entry here and coverage will try one and then the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added .tox\*e\Lib\site-packages\.
This gets used with coverage report - so you could test it after e.g. tox -e py36-coverage -- testing/deprecated_test.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm! 🤗
This should increase coverage for subprocesses, where previously `source` paths were used only from the config file, but not the initial `--source` argument.
2868b39 to
28c9cc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3990 +/- ##
==========================================
+ Coverage 94.48% 94.53% +0.04%
==========================================
Files 107 108 +1
Lines 23663 23686 +23
Branches 2349 2350 +1
==========================================
+ Hits 22358 22391 +33
+ Misses 994 988 -6
+ Partials 311 307 -4
Continue to review full report at Codecov.
|
This should increase coverage for subprocesses, where
sourceis usedonly from the config file, but not the initial
--sourceargument.