Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 6, 2018

If PYTEST_DISABLE_PLUGIN_AUTOLOAD is set, disable auto-loading of
plugins through setuptools entrypoints. Only plugins that have been
explicitly specified are loaded.

ref #3784.

@coveralls
Copy link

coveralls commented Aug 6, 2018

Coverage Status

Coverage increased (+0.05%) to 92.519% when pulling 126896f on hsoft:no-plugin-autoload into a76cc8f on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features August 7, 2018 05:05
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good initial iteration

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor thing, don't block on my review / approval 👍


self.pluginmanager.rewrite_hook = hook

if os.environ.get("PYTEST_DISABLE_PLUGIN_AUTOLOAD", ""):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value can be left out here since get() returns None by default

If `PYTEST_DISABLE_PLUGIN_AUTOLOAD` is set, disable auto-loading of
plugins through setuptools entrypoints. Only plugins that have been
explicitly specified are loaded.

ref #3784.
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @hsoft, thanks!

@nicoddemus nicoddemus merged commit 5f97711 into pytest-dev:features Aug 9, 2018
@nicoddemus
Copy link
Member

Invited @hsoft to join pytest-dev. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants