Skip to content

Conversation

@nicoddemus
Copy link
Member

🎆

.travis.yml Outdated
python: '3.6'
- env: TOXENV=py37
python: 'nightly'
python: 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably put quotes around this at some point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, classical YAML snafu. I will do it on master after we release this. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning behind this (out of curiosity)?
Is Travis gently handling the float here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis allows both float and string here and yaml is funtimes

…ce_bugfix

bugfix in ApproxNumpy initialisation, use keywords for arguments to fix
@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage increased (+0.05%) to 92.544% when pulling 997ef59 on nicoddemus:release-3.7.0 into 9f5d73d on pytest-dev:features.

CHANGELOG.rst Outdated
Bug Fixes
---------

- `#2220 <https://github.com/pytest-dev/pytest/issues/2220>`_: Fix a bug where fixtures overriden by direct parameters (for example parametrization) were being instantiated even if they were not being used by a test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/overriden/overridden/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

CHANGELOG.rst Outdated
Improved Documentation
----------------------

- `#3295 <https://github.com/pytest-dev/pytest/issues/3295>`_: Correct the usage documentation of ``--last-failed-no-failures`` by adding the missing ``--last-failed`` argument in the presented examples, for they are missleading and lead to think that the missing argument is not needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/for they are missleading/because they are misleading/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@blueyed
Copy link
Contributor

blueyed commented Jul 30, 2018

@nicoddemus
Thanks for fixing.
Wonder if you would have preferred me editing/pushing this via Github UI myself?

@nicoddemus
Copy link
Member Author

Wonder if you would have preferred me editing/pushing this via Github UI myself?

Sure, feel free to do so in the future. 👍

@nicoddemus nicoddemus merged commit 2534193 into pytest-dev:features Jul 30, 2018
@nicoddemus nicoddemus deleted the release-3.7.0 branch July 30, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants