[WIP] port cache plugin internals to pathlib #3594
Conversation
| from os.path import sep as _sep, altsep as _altsep | ||
| import shutil | ||
|
|
||
| from . import paths |
There was a problem hiding this comment.
I think you forgot to include paths.py into the commit.
src/_pytest/cacheprovider.py
Outdated
| cachedir.mkdir() | ||
| return cls(cachedir) | ||
|
|
||
| _cachedir = attr.ib(repr=False) |
There was a problem hiding this comment.
For consistency we maybe should keep all attr.ib declarations at the start of the class declaration, before any methods?
src/_pytest/compat.py
Outdated
| else: | ||
| from funcsigs import signature, Parameter as Parameter | ||
| from pathlib2 import Path | ||
| Path |
There was a problem hiding this comment.
Extra symbol here, accident?
|
@RonnyPfannschmidt it seems there's one failing test still. |
|
@nicoddemus test_cache_failure_warns needs the warnings fixed/reintegrated, i'd like to talk about that (hence the the python2 failures are due to my neglect and will be fixed later |
|
man. py34 is broken due to its broken pathlib ^^ part of me wants to drop support, will fix later |
|
Do we have an idea of when we plan to drop py34 btw? |
|
@nicoddemus https://devguide.python.org/#status-of-python-branches - eol is in about 9 months, i#d wait at least another 6 months |
|
Fair enough, thanks for the link! |
|
seems i was wrong about 3.4, needs 3.5 as well i suppose |
| class Cache(object): | ||
|
|
||
| def __init__(self, config): | ||
| self.config = config |
There was a problem hiding this comment.
i realized that removing config and trace is not a good change as its "public" api
RonnyPfannschmidt
changed the title
|
benhoyt/scandir#53 for pypy on windows :/ |
warning logging got broken by detanglement from config
RonnyPfannschmidt
force-pushed
the
interal-pathlib
branch
from
b367009 to
c4c666c
Compare
|
@nicoddemus is it permissible to kill off the windows pypy testing until we can get it to build scandir and/or provide a wheel? |
warning logging got broken by detanglement from config
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.