-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
begin to turn config into package #3535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this prepares the splitting
0d8451f to
bc22472
Compare
| "_pytest._code", | ||
| "_pytest.mark", | ||
| "_pytest.config", | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm curious): any reason these are manually listed instead of using find_packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy
|
@RonnyPfannschmidt would you like to fix the CI so we can merge this? |
|
@nicoddemus yes, but im not sure i an get to it before wednesday |
|
oh wait, its simple |
|
my git repo for pytest got broken, will fix later |
|
there will be followups |
|
OK, thanks for working on this. Btw, what's the motivation? |
|
@nicoddemus its too large to comprehensible figure a path towards non-broken configuration initialization (currently it is broken and only accidentally works for normal usage, its worse under xdist) |
|
@nicoddemus in addition working towards support for toml is also tricky |
|
OK thanks! Just checking if there was another motivation besides making it more manageable/understandable (and there is: toml and sanitize initialization) |
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
|
@asottile anything else you want to take a look here? |
|
nope! all good from me |
|
@asottile want to do the honors and approve/merge this then? 😁 |
this prepares the splitting