Skip to content

Conversation

@RonnyPfannschmidt
Copy link
Member

this prepares the splitting

this prepares the splitting
@coveralls
Copy link

coveralls commented Jun 5, 2018

Coverage Status

Coverage increased (+0.04%) to 92.739% when pulling 1aba123 on RonnyPfannschmidt:config-split into cc793a8 on pytest-dev:master.

"_pytest._code",
"_pytest.mark",
"_pytest.config",
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm curious): any reason these are manually listed instead of using find_packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy

@nicoddemus
Copy link
Member

@RonnyPfannschmidt would you like to fix the CI so we can merge this?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus yes, but im not sure i an get to it before wednesday

@RonnyPfannschmidt
Copy link
Member Author

oh wait, its simple

@RonnyPfannschmidt
Copy link
Member Author

my git repo for pytest got broken, will fix later

@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP] turn config into package begin to turn config into package Jun 11, 2018
@RonnyPfannschmidt
Copy link
Member Author

there will be followups

@nicoddemus
Copy link
Member

OK, thanks for working on this.

Btw, what's the motivation? config.py is too large, or is there another motivation?

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus its too large to comprehensible figure a path towards non-broken configuration initialization (currently it is broken and only accidentally works for normal usage, its worse under xdist)

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus in addition working towards support for toml is also tricky

@nicoddemus
Copy link
Member

nicoddemus commented Jun 11, 2018

OK thanks! Just checking if there was another motivation besides making it more manageable/understandable (and there is: toml and sanitize initialization)

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nicoddemus
Copy link
Member

@asottile anything else you want to take a look here?

@asottile
Copy link
Member

nope! all good from me

@nicoddemus
Copy link
Member

@asottile want to do the honors and approve/merge this then? 😁

@asottile asottile merged commit b285078 into pytest-dev:master Jun 15, 2018
@RonnyPfannschmidt RonnyPfannschmidt deleted the config-split branch August 2, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants