Access captures logs in teardown

[boxed]

This is a fix for the problem seen here: eisensheng/pytest-catchlog#37

I would like to validate some logs globally for the entire test suite. The problem is that caplog gives you one bucket of logs for the phase you're currently in, but I want to check the 'call' bucket when I'm in 'teardown'. This change makes it possible to access all the buckets from all the other.

[coveralls]

Coverage increased (+0.002%) to 92.561% when pulling a1a790e on boxed:access_logs_in_teardown into 3181718 on pytest-dev:master.

[coveralls]

Coverage increased (+0.004%) to 92.562% when pulling a1a790e on boxed:access_logs_in_teardown into 3181718 on pytest-dev:master.

[nicoddemus]

Looks good as a first iteration, thanks!

Some things missing:

• A test for the new feature
• Please rebase this on the features branch because it is a new functionality
• A new change log entry: a file changelog/3117.feature with a brief description of the change, from the POV of an user.

Also I think we should mention this in the documentation, in logging.rst.

Thanks again @boxed!

[boxed]

I can do all that, but notice that I'll document caplog._item, which looks like an internal thing, but now will become a part of the documented API.

[boxed]

@nicoddemus Changes made.

[coveralls]

Coverage increased (+0.006%) to 92.628% when pulling b67badc on boxed:access_logs_in_teardown into 1fd67c9 on pytest-dev:features.

[coveralls]

Coverage increased (+0.004%) to 92.626% when pulling b67badc on boxed:access_logs_in_teardown into 1fd67c9 on pytest-dev:features.

[nicoddemus]

I can do all that, but notice that I'll document caplog._item, which looks like an internal thing, but now will become a part of the documented API.

@boxed good point! I propose we create a get_handler(when) method in the caplog fixture:

def get_handler(self, when):
    """..."""
    return self._item.catch_log_handlers.get(when)

This way we don't expose the entire Item object.

[nicoddemus]

The test looks good, thanks!

[boxed]

I've made the suggested change to introduce a get_handler method. I also added myself to AUTHORS.

[boxed]

I've added a little segment in the docs too... it's not the prettiest text, so suggestions are welcome!

[coveralls]

Coverage increased (+0.006%) to 92.627% when pulling b9fb1cb on boxed:access_logs_in_teardown into 1fd67c9 on pytest-dev:features.

[coveralls]

Coverage increased (+0.006%) to 92.627% when pulling 7ea5a22 on boxed:access_logs_in_teardown into 1fd67c9 on pytest-dev:features.

[nicoddemus]

Thanks @boxed!

[coveralls]

Coverage increased (+0.006%) to 92.627% when pulling c4c968f on boxed:access_logs_in_teardown into 1fd67c9 on pytest-dev:features.