Skip to content

Conversation

@dawranliou
Copy link
Contributor

@dawranliou dawranliou commented Oct 28, 2017

Append example for pytest.param in the example/parametrize document.

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;

Append example for pytest.param in the example/parametrize document.
@dawranliou
Copy link
Contributor Author

This PR is targeting #2658 . Any suggestion is welcome! Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.244% when pulling af5e923 on dawran6:2658 into 111d640 on pytest-dev:master.

@hackebrot hackebrot added the type: docs documentation improvement, missing or needing clarification label Oct 29, 2017
@RonnyPfannschmidt
Copy link
Member

as far as i can tell the ci errors are unrelated,

thanks 👍

@RonnyPfannschmidt RonnyPfannschmidt merged commit d00e2da into pytest-dev:master Oct 30, 2017
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 9, 2017
I spent some time today figuring out why PR pytest-dev#2881 was not showing up
on doc/parametrize... then after some digging even on readthedocs
wondering if the last documentation build had failed, I realized the
docs I was looking for was in doc/example/parametrize instead.

The section that mentions this is very easy to miss, this makes it a
full fledged title and easier to find.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs documentation improvement, missing or needing clarification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants