deprecate the public internal PyCollector.makeitem method

[RonnyPfannschmidt]

… a underscore

[nicoddemus]

Fixed the linting error, after that environment passes it should be safe to merge it.

[nicoddemus]

LGTM @RonnyPfannschmidt, still WIP?

[RonnyPfannschmidt]

i wanted to get feedback on the deprecation first, then fix the details myself in an ammed ^^ - but more around monday

[coveralls]

Coverage decreased (-0.02%) to 92.662% when pulling 290f0b4 on RonnyPfannschmidt:collector-makeitem-deprecate into def471b on pytest-dev:features.

[RonnyPfannschmidt]

@nicoddemus i rebased your fixes along the merge - i#ll add a mocked integration test for the method invocation

[coveralls]

Coverage increased (+0.005%) to 92.685% when pulling a3cedf2 on RonnyPfannschmidt:collector-makeitem-deprecate into cb30848 on pytest-dev:features.

[coveralls]

Coverage decreased (-0.02%) to 92.663% when pulling 766de67 on RonnyPfannschmidt:collector-makeitem-deprecate into cb30848 on pytest-dev:features.

[coveralls]

Coverage increased (+0.005%) to 92.685% when pulling 1a6e782 on RonnyPfannschmidt:collector-makeitem-deprecate into cb30848 on pytest-dev:features.

[coveralls]

Coverage increased (+0.005%) to 92.685% when pulling d1aa553 on RonnyPfannschmidt:collector-makeitem-deprecate into cb30848 on pytest-dev:features.

[nicoddemus]

Thanks @RonnyPfannschmidt