remove preinit, its no longer needed #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
remove-preinit
branch
from
f6f422c to
34909f2
Compare
RonnyPfannschmidt
force-pushed
the
remove-preinit
branch
from
34909f2 to
c68a89b
Compare
nicoddemus
requested changes
Jul 31, 2017
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Nice work!
IMHO we need a small adjustment to the changelog and this is good to go!
changelog/2236.removal
Outdated
| @@ -0,0 +1 @@ | |||
| - remove plugin preinit, we no longer need to do that because the namespace is initialized in the module now No newline at end of file | |||
Member
There was a problem hiding this comment.
I suggest to make this more user oriented, the way it is now I doubt the general user will understand it. How about:
Remove internal ``_preloadplugins()`` function. This removal is part of the ``pytest_namespace()`` hook deprecation.
nicoddemus
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by removing preinit we remove loading the initial plugin list
this is no longer needed, since we no longer use pytest-namespace for pytest itself
the followup for this one is to deprecate the pytest-namespace hook alltogether