use consistent inner repressentation for marks #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
added
the
type: proposal
flub
reviewed
Sep 19, 2016
Member
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Looks good! Would be nice to avoid the internal mark API in the skipping plugin though.
| else: | ||
| arglist = [(self.holder.args, self.holder.kwargs)] | ||
| for args, kwargs in arglist: | ||
| marks = getattr(self.holder, '_marks', None) \ |
Member
There was a problem hiding this comment.
Not that this is made worse by this PR but it's not nice that this uses an internal attribute of the MarkInfo. Should markinfo not make this public somehow instead? How about using the MarkInfo as an iterator? I think that gives you access to all args/kwargs individually.
Member
Author
There was a problem hiding this comment.
@flub when i did this the first time (the pr we rejected at the sprint)
i did move this code into the marks module
i plan to fix it eventually, but that was not in the scope of this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr makes the internals of markers a more consistent structure to use as a base for future enhancements
currently the new mark type is not exposed,
but it is a intent to remove usages of MarkInfo/MarkDecorator in favor of Mark objects and potentially collections/views over them later on