Skip to content

[PR #13621/836cfbac backport][8.4.x] selftests: Set a timeout for lsof #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.4.x
Choose a base branch
from
Open

[PR #13621/836cfbac backport][8.4.x] selftests: Set a timeout for lsof #13623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/13621.contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pytest's own testsuite now handles the ``lsof`` command hanging (e.g. due to unreachable network filesystems), with the affected selftests being skipped after 10 seconds.
9 changes: 7 additions & 2 deletions testing/test_capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,13 @@ def tmpfile(pytester: Pytester) -> Generator[BinaryIO]:
def lsof_check():
pid = os.getpid()
try:
out = subprocess.check_output(("lsof", "-p", str(pid))).decode()
except (OSError, subprocess.CalledProcessError, UnicodeDecodeError) as exc:
out = subprocess.check_output(("lsof", "-p", str(pid)), timeout=10).decode()
except (
OSError,
UnicodeDecodeError,
subprocess.CalledProcessError,
subprocess.TimeoutExpired,
) as exc:
# about UnicodeDecodeError, see note on pytester
pytest.skip(f"could not run 'lsof' ({exc!r})")
yield
Expand Down
Loading