Copy docstrings to wrapped pdb methods #12947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
reviewed
Nov 8, 2024
adamchainz
force-pushed
the
pdb_docstrings
branch
from
e5679c5 to
c27a64f
Compare
Member
|
Hmm the tests are failing, can you take a look @adamchainz ? |
webknjaz
reviewed
Nov 10, 2024
| do_c = do_cont = do_continue | ||
|
|
||
| def do_quit(self, arg): | ||
| """Raise Exit outcome when quit command is used in pdb. |
Member
There was a problem hiding this comment.
Seems reasonable to copy the original docstring from do_quit, which is the purpose of the PR... turning into a comment makes sure we do not lose that information.
Member
Author
There was a problem hiding this comment.
Yeah, I changed this because it won't be the real docstring at runtime after __doc__ is set.
adamchainz
force-pushed
the
pdb_docstrings
branch
2 times, most recently
from
ecc28fe to
6827227
Compare
Co-authored-by: Bruno Oliveira <[email protected]> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
adamchainz
force-pushed
the
pdb_docstrings
branch
from
6827227 to
cc0b883
Compare
Member
|
Thanks @adamchainz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12946.