config: stop using exception triplets in ConftestImportError
#11817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent python versions all of the info is on the exception object itself so no reason to deal with the annoying tuple.
nicoddemus
approved these changes
Jan 15, 2024
| assert e.__traceback__ is not None | ||
| exc_info = (type(e), e, e.__traceback__) | ||
| raise ConftestImportFailure(conftestpath, exc_info) from e | ||
| raise ConftestImportFailure(conftestpath, cause=e) from e |
Member
There was a problem hiding this comment.
Isn't that data available via the context?
Member
Author
There was a problem hiding this comment.
Yes, I started by using __cause__ but there are some issues with that, the typing is more annoying (can be None) and it's not available in the ctor, so went with the direct conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent python versions all of the info is on the exception object itself so no reason to deal with the annoying tuple.