-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
status: criticalgrave problem or usability issue that affects lots of usersgrave problem or usability issue that affects lots of userstype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelogtype: regressionindicates a problem that was introduced in a release which was working previouslyindicates a problem that was introduced in a release which was working previously
Milestone
Description
the introductin of various startpath
/fspath
hooks in the hookspecs
as a non-optional and non-inmplied parameter is practically a api breaking change
back in 2018 i decoded to close the upstream issue in pytest-dev/pluggy#15 as its pretty much insanely complex to alter the hooks where callers and callees are not under good control
the pr adding them is #8144
CC @bluetech
i believe/fear the correct solution would be to deprecate the old hook names, introduce a new hook version and have invoking/implementing the old one trigger a deprecation warning
Metadata
Metadata
Assignees
Labels
status: criticalgrave problem or usability issue that affects lots of usersgrave problem or usability issue that affects lots of userstype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelogtype: regressionindicates a problem that was introduced in a release which was working previouslyindicates a problem that was introduced in a release which was working previously