Hi,
I was analyzing the test sorting algorithm and it stumbled upon this function setall which does not seem to be called by anything in the code:
|
def setall(self, funcargs, id, param): |
|
for x in funcargs: |
|
self._checkargnotcontained(x) |
|
self.funcargs.update(funcargs) |
|
if id is not NOTSET: |
|
self._idlist.append(id) |
|
if param is not NOTSET: |
|
assert self._globalparam is NOTSET |
|
self._globalparam = param |
|
for arg in funcargs: |
|
self._arg2scopenum[arg] = fixtures.scopenum_function |
Could anyone confirm that is the case? If so, guess it could be removed? I could do this quick PR.
It seems it was superseded by setmulti2?
|
def setmulti2(self, valtypes, argnames, valset, id, marks, scopenum, param_index): |
|
for arg, val in zip(argnames, valset): |
|
self._checkargnotcontained(arg) |
|
valtype_for_arg = valtypes[arg] |
|
getattr(self, valtype_for_arg)[arg] = val |
|
self.indices[arg] = param_index |
|
self._arg2scopenum[arg] = scopenum |
|
self._idlist.append(id) |
|
self.marks.extend(normalize_mark_list(marks)) |
