3.7.0: Hookspec method signature regression

[jperras]

When upgrading from pytest 3.6.x to 3.7, it seems as though the signature for hookspec has changed:

Traceback (most recent call last):
  File "<redacted>/python3.6/site-packages/_pytest/hookspec.py", line 27, in <module>
    @hookspec(historic=True, warn_on_impl=PYTEST_NAMESPACE)
TypeError: __call__() got an unexpected keyword argument 'warn_on_impl'
ERROR: InvocationError for command '<redacted>/bin/pytest -x --pdb' (exited with code 1)

Reverting back to 3.6.4 fixes the issue.

Plugins being used:

    pytest-mock
    pytest-asyncio
    pytest_profiling

[nicoddemus]

Hi @jperras,

The hook signature did not change, but we are passing the warn_on_impl option to pluggy which is featured in pluggy 0.7. Which pluggy version do you have installed?

[jperras]

I believe the version that was running that caused the error was pluggy==0.6.0; I've performed a few permutations of the package versions when debugging the issue, so it's possible that I am also reporting the incorrect version.

The error was encountered during an automated test run that installed pytest and the various dependencies; perhaps there is an order-dependent installation issue that I had not noticed until now.

Our tox.ini segment that prepares the testing environment dependencies:

deps=
    freezegun
    pytest-mock
    pytest
    pyserial
    pytest-asyncio
    websockets
    pytest_profiling
    -rrequirements.txt

[nicoddemus]

It might be pip dependency resolver playing tricks then, because pytest 3.7 does require pluggy>=0.7:

pytest/setup.py

Line 72 in 2534193

install_requires.append("pluggy>=0.7")

I suggest to try recreating the environment with -r to see if the problem goes away.

[nedbat]

This is happening to me on Travis, even after I clear the caches, but only on some of the jobs? https://travis-ci.com/nedbat/coveragepy/builds/81086869 The failures are on the jobs measuring coverage, which might reuse the environment (I'm unclear on the Travis details).

[RonnyPfannschmidt]

@nedbat looks like travis is broken

[nedbat]

The problem seems to be that tox has this requirement: pluggy<1,>=0.3.0 and pip gets confused. I've solved it by adding "pluggy>=0.7" to my own requirements file.

[RonnyPfannschmidt]

@nedbat neat find, thanks for sharing, it might need a fix in tox

[nicoddemus]

Closing as this is not really related to pytest. Thanks to all participants!