Skip to content

Commit 12e2763

Browse files
author
Philipp Loose
committed
Move stacklevel tests into test_warnings module
The tests are grouped in a class called TestStackLevel.
1 parent ab17a00 commit 12e2763

File tree

2 files changed

+94
-94
lines changed

2 files changed

+94
-94
lines changed

‎testing/acceptance_test.py‎

Lines changed: 0 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,97 +1238,3 @@ def test_3():
12381238
assert (
12391239
result.stdout.str().count("async def functions are not natively supported") == 1
12401240
)
1241-
1242-
1243-
def test_issue4445_rewrite(testdir):
1244-
"""#4445: Make sure the warning points to a reasonable location
1245-
See origin of _issue_warning_captured at: _pytest.assertion.rewrite.py:241
1246-
"""
1247-
testdir.makepyfile(some_mod="")
1248-
testdir.makeconftest(
1249-
"""
1250-
import some_mod
1251-
import pytest
1252-
1253-
pytest.register_assert_rewrite("some_mod")
1254-
"""
1255-
)
1256-
result = testdir.runpytest()
1257-
# with stacklevel=5 the warning originates from register_assert_rewrite
1258-
# function in the created conftest.py
1259-
result.stdout.fnmatch_lines(
1260-
["*conftest.py:4*", "*Module already imported*", "*some_mod*"]
1261-
)
1262-
1263-
1264-
def test_issue4445_preparse(testdir):
1265-
"""#4445: Make sure the warning points to a reasonable location
1266-
See origin of _issue_warning_captured at: _pytest.config.__init__.py:910
1267-
"""
1268-
testdir.makeconftest(
1269-
"""
1270-
import nothing
1271-
"""
1272-
)
1273-
result = testdir.runpytest("--help")
1274-
# with stacklevel=2 the warning originates from config._preparse and is
1275-
# thrown by an errorneous conftest.py
1276-
result.stdout.fnmatch_lines_random(
1277-
[
1278-
"*config{sep}__init__.py:915*".format(sep=os.sep),
1279-
"*could not load initial conftests*",
1280-
]
1281-
)
1282-
1283-
1284-
def test_issue4445_import_plugin(testdir):
1285-
"""#4445: Make sure the warning points to a reasonable location
1286-
See origin of _issue_warning_captured at: _pytest.config.__init__.py:585
1287-
"""
1288-
testdir.makepyfile(
1289-
some_plugin="""
1290-
import pytest
1291-
pytest.skip("thing", allow_module_level=True)
1292-
"""
1293-
)
1294-
result = testdir.runpytest("-p", "some_plugin", syspathinsert=True)
1295-
# with stacklevel=2 the warning originates from
1296-
# config.PytestPluginManager.import_plugin is thrown by a skipped plugin
1297-
result.stdout.fnmatch_lines(
1298-
[
1299-
"*config{sep}__init__.py:588*".format(sep=os.sep),
1300-
"*skipped plugin 'some_plugin': thing*",
1301-
]
1302-
)
1303-
1304-
1305-
def test_issue4445_resultlog(testdir):
1306-
"""#4445: Make sure the warning points to a reasonable location
1307-
See origin of _issue_warning_captured at: _pytest.resultlog.py:35
1308-
"""
1309-
testdir.makepyfile(
1310-
"""
1311-
def test_dummy():
1312-
pass
1313-
"""
1314-
)
1315-
result = testdir.runpytest(
1316-
"--result-log={dir}".format(dir=testdir.tmpdir.join("result.log"))
1317-
)
1318-
# with stacklevel=2 the warning originates from resultlog.pytest_configure
1319-
# and is thrown when --result-log is used
1320-
result.stdout.fnmatch_lines(["*resultlog.py:35*", "*--result-log is deprecated*"])
1321-
1322-
1323-
def test_issue4445_cacheprovider_set(testdir):
1324-
"""#4445: Make sure the warning points to a reasonable location
1325-
See origin of _issue_warning_captured at: _pytest.cacheprovider.py:59
1326-
"""
1327-
testdir.tmpdir.join(".pytest_cache").write("something wrong")
1328-
result = testdir.runpytest()
1329-
# with stacklevel=3 the warning originates from one stacklevel above
1330-
# _issue_warning_captured in cacheprovider.Cache.set and is thrown
1331-
# when there are errors during cache folder creation
1332-
result.stdout.fnmatch_lines(
1333-
["*cacheprovider.py:120*", "*could not create cache path*"]
1334-
)

‎testing/test_warnings.py‎

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import os
12
import warnings
23

34
import pytest
@@ -640,3 +641,96 @@ def pytest_configure():
640641
assert "INTERNALERROR" not in result.stderr.str()
641642
warning = recwarn.pop()
642643
assert str(warning.message) == "from pytest_configure"
644+
645+
646+
class TestStackLevel:
647+
def test_issue4445_rewrite(self, testdir):
648+
"""#4445: Make sure the warning points to a reasonable location
649+
See origin of _issue_warning_captured at: _pytest.assertion.rewrite.py:241
650+
"""
651+
testdir.makepyfile(some_mod="")
652+
testdir.makeconftest(
653+
"""
654+
import some_mod
655+
import pytest
656+
657+
pytest.register_assert_rewrite("some_mod")
658+
"""
659+
)
660+
result = testdir.runpytest()
661+
# with stacklevel=5 the warning originates from register_assert_rewrite
662+
# function in the created conftest.py
663+
result.stdout.fnmatch_lines(
664+
["*conftest.py:4*", "*Module already imported*", "*some_mod*"]
665+
)
666+
667+
def test_issue4445_preparse(self, testdir):
668+
"""#4445: Make sure the warning points to a reasonable location
669+
See origin of _issue_warning_captured at: _pytest.config.__init__.py:910
670+
"""
671+
testdir.makeconftest(
672+
"""
673+
import nothing
674+
"""
675+
)
676+
result = testdir.runpytest("--help")
677+
# with stacklevel=2 the warning originates from config._preparse and is
678+
# thrown by an errorneous conftest.py
679+
result.stdout.fnmatch_lines_random(
680+
[
681+
"*config{sep}__init__.py:915*".format(sep=os.sep),
682+
"*could not load initial conftests*",
683+
]
684+
)
685+
686+
def test_issue4445_import_plugin(self, testdir):
687+
"""#4445: Make sure the warning points to a reasonable location
688+
See origin of _issue_warning_captured at: _pytest.config.__init__.py:585
689+
"""
690+
testdir.makepyfile(
691+
some_plugin="""
692+
import pytest
693+
pytest.skip("thing", allow_module_level=True)
694+
"""
695+
)
696+
result = testdir.runpytest("-p", "some_plugin", syspathinsert=True)
697+
# with stacklevel=2 the warning originates from
698+
# config.PytestPluginManager.import_plugin is thrown by a skipped plugin
699+
result.stdout.fnmatch_lines(
700+
[
701+
"*config{sep}__init__.py:588*".format(sep=os.sep),
702+
"*skipped plugin 'some_plugin': thing*",
703+
]
704+
)
705+
706+
def test_issue4445_resultlog(self, testdir):
707+
"""#4445: Make sure the warning points to a reasonable location
708+
See origin of _issue_warning_captured at: _pytest.resultlog.py:35
709+
"""
710+
testdir.makepyfile(
711+
"""
712+
def test_dummy():
713+
pass
714+
"""
715+
)
716+
result = testdir.runpytest(
717+
"--result-log={dir}".format(dir=testdir.tmpdir.join("result.log"))
718+
)
719+
# with stacklevel=2 the warning originates from resultlog.pytest_configure
720+
# and is thrown when --result-log is used
721+
result.stdout.fnmatch_lines(
722+
["*resultlog.py:35*", "*--result-log is deprecated*"]
723+
)
724+
725+
def test_issue4445_cacheprovider_set(self, testdir):
726+
"""#4445: Make sure the warning points to a reasonable location
727+
See origin of _issue_warning_captured at: _pytest.cacheprovider.py:59
728+
"""
729+
testdir.tmpdir.join(".pytest_cache").write("something wrong")
730+
result = testdir.runpytest()
731+
# with stacklevel=3 the warning originates from one stacklevel above
732+
# _issue_warning_captured in cacheprovider.Cache.set and is thrown
733+
# when there are errors during cache folder creation
734+
result.stdout.fnmatch_lines(
735+
["*cacheprovider.py:120*", "*could not create cache path*"]
736+
)

0 commit comments

Comments
 (0)