Change _issue_warning_captured stacklevel to 2 in config.PytestPluginManager

Philipp Loose · Philipp Loose · commit ab17a0060c68 · 2019-10-17T17:19:05.000+02:00
The import_plugin method should be the origin of the warning not the
deeper warning from the warnings module.
diff --git a/src/_pytest/config/__init__.py b/src/_pytest/config/__init__.py
@@ -585,7 +585,7 @@ def import_plugin(self, modname, consider_entry_points=False):
             _issue_warning_captured(
                 PytestConfigWarning("skipped plugin {!r}: {}".format(modname, e.msg)),
                 self.hook,
-                stacklevel=1,
+                stacklevel=2,
             )
         else:
             mod = sys.modules[importspec]

Original file line number	Diff line number	Diff line change
`@@ -585,7 +585,7 @@ def import_plugin(self, modname, consider_entry_points=False):`
`585`	`585`	`_issue_warning_captured(`
`586`	`586`	`PytestConfigWarning("skipped plugin {!r}: {}".format(modname, e.msg)),`
`587`	`587`	`self.hook,`
`588`		`- stacklevel=1,`
	`588`	`+ stacklevel=2,`
`589`	`589`	`)`
`590`	`590`	`else:`
`591`	`591`	`mod = sys.modules[importspec]`