Add --maxschedchunk CLI option #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amezin
force-pushed
the
limit-sched-chunk-size
branch
from
0c23da7 to
de012b9
Compare
Maximum number of tests scheduled in one step. Setting it to 1 will force pytest to send tests to workers one by one - might be useful for a small number of slow tests. Larger numbers will allow the scheduler to submit consecutive chunks of tests to workers - allows reusing fixtures. Unlimited if not set. Fixes pytest-dev#855
amezin
force-pushed
the
limit-sched-chunk-size
branch
from
1b0ebc7 to
8a7ef66
Compare
Collaborator
Author
|
While this solves #855, it's an ugly workaround IMO. The more I look at the scheduling problem, the more I think it should be solved using work stealing https://en.wikipedia.org/wiki/Work_stealing. Described in detail in #858 |
nicoddemus
requested changes
Dec 21, 2022
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @amezin!
Please take a look at my comments. 👍
Co-authored-by: Bruno Oliveira <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum number of tests scheduled in one step.
Setting it to 1 will force pytest to send tests to workers one by one - might be useful for a small number of slow tests.
Larger numbers will allow the scheduler to submit consecutive chunks of tests to workers - allows reusing fixtures.
Unlimited if not set.
Fixes #855
Fixes #255