Skip to content

Conversation

@RonnyPfannschmidt
Copy link
Member

modern setuptools_scm drops python 3.6

  • use build isolation
  • drop setup_requires

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

modern setuptools_scm drops python 3.6

* use build isolation
* drop setup_requires
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RonnyPfannschmidt! 🙇

@nicoddemus nicoddemus merged commit 8616ff3 into master Jul 13, 2022
@nicoddemus nicoddemus deleted the fix-setuptools-scm branch July 13, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants