Skip to content

Ignore Python 3.8 specific failure in pytest for now #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

Ignore Python 3.8 specific failure in pytest for now #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions testing/acceptance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ def test_fail2():
assert result.ret == 2
result.stdout.fnmatch_lines(["*Interrupted: stopping*1*", "*1 failed*"])

@pytest.mark.xfail(
reason="#527: Python 3.8 failure in pytest where testdir.tmpdir returns an unexpected value"
)
def test_basetemp_in_subprocesses(self, testdir):
p1 = testdir.makepyfile(
"""
Expand Down Expand Up @@ -186,6 +189,7 @@ def test_crash():
)
assert result.ret == 1

@pytest.mark.xfail(reason="#527: Ignore Python 3.8 failure for the time being")
Copy link
Contributor

@blueyed blueyed Jul 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference: I do not think this is py38 specific, but rather pytest related only (pytest-dev/pytest#6981 (comment)).
(just leaving this here since I was confused why pytestmaster was not failing anymore)

Build log for the (now swallowed) failure: https://travis-ci.org/github/pytest-dev/pytest-xdist/jobs/669139507#L255

def test_distribution_rsyncdirs_example(self, testdir, monkeypatch):
# use a custom plugin that has a custom command-line option to ensure
# this is propagated to workers (see #491)
Expand Down