-
Notifications
You must be signed in to change notification settings - Fork 248
Open
Labels
InfrastructureChanges related to project infrastructure ( CI/CD, deploy mechanism, etc. )Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )proposalThis issue/PR is meant to gather feedback on an idea/changeThis issue/PR is meant to gather feedback on an idea/change
Description
Could we change this package to use https://docs.python.org/3/library/importlib.html#importlib.resources.read_text? instead of pkg_resources from setuptools?
I see the following advantages
- pip installing setuptools doesn't play nice with tools like https://github.com/jazzband/pip-tools
- pkg_resources doesn't work with pyoxidizer https://pyoxidizer.readthedocs.io/en/stable/,
- importlib is part of the std library, meaning we have one less dependency (we can't always assume setuptools is going to be available, especially with things like pyinstaller, pyoxidize, etc)
The readme says we need python3.6 or newer, so we should be fine for compatibility, as importlib was added in 3.1.
I'll put up a PR shortly, its a pretty minimal change
Metadata
Metadata
Assignees
Labels
InfrastructureChanges related to project infrastructure ( CI/CD, deploy mechanism, etc. )Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )proposalThis issue/PR is meant to gather feedback on an idea/changeThis issue/PR is meant to gather feedback on an idea/change