Skip to content

Conversation

@youtux
Copy link
Contributor

@youtux youtux commented Dec 5, 2024

Fix regression of #749 where we would serialize the scenario.description as null instead of the empty string.

@youtux
Copy link
Contributor Author

youtux commented Dec 5, 2024

@jsa34 FYI

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (6cdd340) to head (2a3af16).
Report is 65 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          55       55           
  Lines        2250     2250           
  Branches      246      246           
=======================================
  Hits         2162     2162           
  Misses         53       53           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youtux
Copy link
Contributor Author

youtux commented Dec 5, 2024

It turns out there was no bug, only our Scenario and ScenarioTemplate typing is incorrect. Will fix them in #658

@youtux youtux closed this Dec 5, 2024
@youtux youtux deleted the ab/fix-description-emtpy-string branch December 5, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants